Skip to content

Conversation

@EvilOlaf
Copy link
Member

@EvilOlaf EvilOlaf commented Jan 29, 2026

Description

Extracted a bit too much from Megi. Remove some non-sunxi related patches.

How Has This Been Tested?

  • hasn't

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Revert
    • Removed kernel patches affecting USB Type-C connectivity, backlight brightness control, WiFi integration, charger detection, USB PHY power management, and SPI flash clock configuration across multiple hardware platforms.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

Multiple kernel patches for Sunxi 6.18 are being removed, including six patches for RK3566 PineTab2 device tree customizations (PWM brightness, USB Type-C controller, extcon bridge, charger detection, wifi/UART integration, SPI flash clock) and six RK3399 Type-C support patches (CDN DP, PHY delays, charger detection, USB3 PHY power tracking, Type-C fallback, DWC3 reset quirk). The series configuration is also updated to disable these patches from being applied.

Changes

Cohort / File(s) Summary
PineTab2 Device Tree Patches
patch/kernel/archive/sunxi-6.18/patches.megous/pt2-6.18/0001-...-brightness.patch, 0002-...-Type-C-controller.patch, 0003-...-extcon-bridge.patch, 0004-...-tcpci.patch, 0005-...-besdbg.patch, 0006-...-SPI-NOR-flash.patch
Removal of six patches affecting RK3566 PineTab2: PWM brightness curve, USB Type-C controller, extcon bridge, input current limits, BES2600 wifi/UART integration, and SPI flash clock frequency adjustments.
RK3399 Type-C Patches
patch/kernel/archive/sunxi-6.18/patches.megous/rk3399-typec-6.18/0001-...-CDN-DP.patch, 0002-...-USB2-delay.patch, 0003-...-charger-detection.patch, 0004-...-USB3-PHY-power.patch, 0005-...-naneng.patch, 0006-...-reset-quirk.patch
Removal of six patches for RK3399 Type-C support: CDN DP disable on disconnect, PHY delay adjustments, charger detection robustness, USB3 PHY power state tracking, Type-C fallback configuration, and DWC3 reset quirk role-switch handling.
Series Configuration
patch/kernel/archive/sunxi-6.18/series.conf
Removal of 12 patch entries from series configuration, disabling previously applied patches across pt2-6.18, rk3399-typec-6.18, and related directories.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • PanderMusubi
  • igorpecovnik
  • TheSnowfield
  • pyavitz

Poem

🐰 Patches once added, now take their leave,
Type-C and brightness—no more reprieve,
The kernel grows lean, the config runs clean,
Removing the clutter that cluttered the scene! 🌱

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing unneeded patches from the sunxi kernel archive configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 02 Milestone: First quarter release size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/large PR with 250 lines or more

Development

Successfully merging this pull request may close these issues.

1 participant