Increase speed of finding components in large swing hierarchy.#261
Open
SeanBurnsUK wants to merge 2 commits intoassertj:mainfrom
Open
Increase speed of finding components in large swing hierarchy.#261SeanBurnsUK wants to merge 2 commits intoassertj:mainfrom
SeanBurnsUK wants to merge 2 commits intoassertj:mainfrom
Conversation
…ue hundreds possible millions of blocking events for the swing thread.
|
Sounds like a sensible thing to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a large swing hierarchy with many thousands of components.
The find is VERY slow because while doing a depth first search of the hierarchy all recursive loops and match checks are queued for the swing thread and block until done.
This change causes the entire search to be done with just a single blocking invocation on the swing thread. This significantly improves the time needed to do a search on the hierarchy.