fix(event-handler): handle set-cookie header values with multiple attributes#4990
Merged
svozza merged 6 commits intoaws-powertools:mainfrom Feb 10, 2026
Merged
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
dreamorosi
previously requested changes
Feb 5, 2026
svozza
reviewed
Feb 5, 2026
nateiler
commented
Feb 5, 2026
My comments were addressed, will leave to @svozza to bring the PR to merge state.
svozza
approved these changes
Feb 10, 2026
Contributor
|
Thank you @nateiler for your work on this. Approved. |
|
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
This fixes the scenario where a single
set-cookieheader valuefoo=bar; Max-Age=3600is treated as twoset-cookievalues because multiple values may be separated by a;.Changes
When parsing the headers,
set-cookieheaders are handled using the getSetCookie method.Logic to detect multiple header entries has been removed as multiple header values are appended to a single header (via comma).
Issue number: closes #4986
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.