Merged
Conversation
zoewangg
commented
Feb 2, 2026
| toThrow = new ConnectException(httpException.getMessage()); | ||
| return new SSLHandshakeException(httpException.getMessage()); | ||
| } | ||
| // TODO: check with CRT team, could CRT_SOCKET_TIMEOUT be thrown |
| } | ||
|
|
||
| @Test | ||
| public void execute_AcquireConnectionFailure_shouldAlwaysWrapIOException() { |
Contributor
Author
There was a problem hiding this comment.
This test was deleted because after the new stream manager change, there's no stream.activate() invocation anymore and the exception will only be surfaced through failed completable future, which is already covered in execute_retryableException_wrapsWithIOException
| clientTlsContextOptions = clientTlsContextOptions.withAlpnList("h2"); | ||
| } | ||
|
|
||
| try (ClientBootstrap clientBootstrap = new ClientBootstrap(null, null); |
Contributor
Author
There was a problem hiding this comment.
Removed try-catch because it's no longer needed and we removed subresource.addRef() to keep the logic simple
RanVaknin
reviewed
Feb 5, 2026
...ients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/AwsCrtHttpClientBase.java
Show resolved
Hide resolved
...ients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/AwsCrtHttpClientBase.java
Show resolved
Hide resolved
RanVaknin
approved these changes
Feb 5, 2026
dagnir
approved these changes
Feb 6, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add HTTP/2 support to the AWS CRT HTTP client. This enables customers to use HTTP/2 with the CRT async HTTP client for improved performance with services
that support HTTP/2, such as Transcribe Streaming and Kinesis.
This PR targets the feature branch for initial review before merging to master.
Modifications
Core Changes
Migrated from
HttpClientConnectionManagertoHttpStreamManagerAPI for both HTTP/1.1 and HTTP/2 supportKey differences between
HttpClientConnectionManagerandHttpStreamManagerThe new HttpStreamManager API abstracts away connection management, making it protocol-agnostic. For HTTP/1.1, it's one stream per connection. For HTTP/2, multiple streams can share a single connection (multiplexing).
Request/Response Handling
Error Handling
hang
Test Updates
Testing
Types of changes
Checklist
Commit the new file created by the script in .changes/next-release with your changes.
LaunchChangelog.md)
License