Skip to content

Fix Endpoint StringArray Parameter + operationContextParams issues#6712

Merged
alextwoods merged 8 commits intomasterfrom
alexwoo/endpoint-stringarray-fixes
Feb 12, 2026
Merged

Fix Endpoint StringArray Parameter + operationContextParams issues#6712
alextwoods merged 8 commits intomasterfrom
alexwoo/endpoint-stringarray-fixes

Conversation

@alextwoods
Copy link
Contributor

@alextwoods alextwoods commented Feb 4, 2026

Fix Endpoint StringArray Parameter + operationContextParams issues

Motivation and Context

There are a few issues in our implementations of StringArray type Endpoint Parameters and the various bindings:

  • Incomplete support for parsing chained index expressions
  • incomplete support for MultiSelect lists - both in parsing and in generating acceptor code.
  • incorrect logic for including JmesPathRuntime
  • StaticContextParams with stringarrays are not handled.

Note: The first two of these apply to general JmesPath support and improve support for Waiters as well as endpoints.

Modifications

  • Add the Smithy Standard string-array test model and a complete suite of tests for the bindings defined there. This is the standard test suite that caught the above issues.
  • Add support for parsing chainged index expressions w/ multi-select lists
  • Add support generating acceptor code for multiselect lists
  • Add support for StaticContextParams with StringArrays
  • Fix logic used to determine if we include JmesPathRuntime

Testing

  • Added standard smithy string-array test model + suite
  • New JmesPath parser and acceptor generator tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods marked this pull request as ready for review February 4, 2026 20:44
@alextwoods alextwoods requested a review from a team as a code owner February 4, 2026 20:44
@alextwoods alextwoods changed the title Alexwoo/endpoint stringarray fixes Fix Endpoint StringArray Parameter + operationContextParams issues Feb 4, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

@RanVaknin RanVaknin self-requested a review February 12, 2026 18:23
"type": "bugfix",
"category": "AWS SDK for Java v2",
"contributor": "",
"description": "Improve support for operationContextParams with chained index and multi-select expressions and improve support for StringArray endpoint parametes."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in parameters*

@alextwoods alextwoods added this pull request to the merge queue Feb 12, 2026
Merged via the queue into master with commit 685e012 Feb 12, 2026
37 of 40 checks passed
@github-actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants