Skip to content

Disable smoke test verification in release.yaml #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sachinh-amazon merged 1 commit into from
Feb 9, 2026
Merged

Disable smoke test verification in release.yaml #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,33 +37,33 @@ jobs:
fi
echo "Tag is from a valid branch."

- name: Verify smoke tests passed
run: |
echo "Checking smoke test results for commit $COMMIT_SHA..."
# - name: Verify smoke tests passed
# run: |
# echo "Checking smoke test results for commit $COMMIT_SHA..."

# Find smoke test runs for this commit
RUN_INFO=$(gh run list --workflow=smoke-tests-sagemaker.yaml --json headSha,conclusion,status --limit 50 | \
jq -r --arg sha "$COMMIT_SHA" '.[] | select(.headSha == $sha) | "\(.status) \(.conclusion)"' | head -1)
# # Find smoke test runs for this commit
# RUN_INFO=$(gh run list --workflow=smoke-tests-sagemaker.yaml --json headSha,conclusion,status --limit 50 | \
# jq -r --arg sha "$COMMIT_SHA" '.[] | select(.headSha == $sha) | "\(.status) \(.conclusion)"' | head -1)

if [ -z "$RUN_INFO" ]; then
echo "Error: No smoke test run found for commit $COMMIT_SHA"
exit 1
fi
# if [ -z "$RUN_INFO" ]; then
# echo "Error: No smoke test run found for commit $COMMIT_SHA"
# exit 1
# fi

STATUS=$(echo "$RUN_INFO" | cut -d' ' -f1)
CONCLUSION=$(echo "$RUN_INFO" | cut -d' ' -f2)
# STATUS=$(echo "$RUN_INFO" | cut -d' ' -f1)
# CONCLUSION=$(echo "$RUN_INFO" | cut -d' ' -f2)

if [ "$STATUS" != "completed" ]; then
echo "Error: Smoke tests not completed (status: $STATUS)"
exit 1
fi
# if [ "$STATUS" != "completed" ]; then
# echo "Error: Smoke tests not completed (status: $STATUS)"
# exit 1
# fi

if [ "$CONCLUSION" != "success" ]; then
echo "Error: Smoke tests failed (conclusion: $CONCLUSION)"
exit 1
fi
# if [ "$CONCLUSION" != "success" ]; then
# echo "Error: Smoke tests failed (conclusion: $CONCLUSION)"
# exit 1
# fi

echo "Smoke tests passed for commit $COMMIT_SHA"
# echo "Smoke tests passed for commit $COMMIT_SHA"

- name: Download sagemaker artifacts by commit ID
run: |
Expand Down Expand Up @@ -163,4 +163,4 @@ jobs:
--namespace "GitHub/Workflows" \
--metric-name "ExecutionsFailed" \
--dimensions "Repository=$REPOSITORY,Workflow=Release" \
--value 1
--value 1
Loading