Open
Conversation
bartventer
previously approved these changes
Jan 12, 2026
Dismissing my approval since the affected tests need to be updated to match the new logic. See my review comment for details.
The lint workflow failure is just pointing out some outdated file headers. I'll fix those before the next release.
Author
|
I can't see the comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the cache is stale, it fails to freshen the headers upon receiving a 304 response, resulting in re-validation for every subsequent request.
From https://www.rfc-editor.org/rfc/rfc9111.html#section-4.3.4