fix: avoid duplicate package suffix in Go benchmarks [#336] #337
fix: avoid duplicate package suffix in Go benchmarks [#336] #337
Conversation
Add new action input to force package suffix on Go benchmark names even when the name already contains a package reference. This allows users to opt for consistent naming when the automatic duplicate detection doesn't match their use case.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new boolean input Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 89.13% 89.24% +0.11%
==========================================
Files 16 16
Lines 948 958 +10
Branches 201 205 +4
==========================================
+ Hits 845 855 +10
Misses 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @gaby, @ReneWerner87 Before I publish the new version, I wanted to make sure that it doesn't break your existing workaround by adding this new feature for including the package name. There is a separate action input to force it to use the package names when possible, but if it finds the package name in the benchmark name, it won't do it. Chris, could you have a look at this PR and give me a green light that it should work as expected for gofiber? |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 535-547: The MD003 warning is because the new input section uses
ATX "#### `go-force-package-suffix` (Optional)" instead of the expected setext
style; change the heading for the `go-force-package-suffix` section to setext
style by replacing the ATX heading with the plain heading text
"go-force-package-suffix (Optional)" followed by an underline of '=' (or '-' for
subheading) on the next line so markdownlint MD003 passes, or alternatively
adjust the lint rule if setext is not desired.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
.claude/skills/github-issues/SKILL.mdREADME.mdaction.ymlsrc/config.tssrc/extract.tstest/config.spec.tstest/extractGoResult.spec.tstest/write.spec.ts

resolves #336
package names in benchmark names
path, underscored, or ≥2 trailing segments) and skips suffix
detection
Summary by CodeRabbit
New Features
Documentation
Tests