fix: restore function-based streaming body support (#821)#826
Merged
fix: restore function-based streaming body support (#821)#826
Conversation
In hackney 1.25.0, send_body/2 accepted functions for iterative body
streaming. In 3.0.2, this was broken because functions were passed
directly to encode_chunk/1 which only handles binary/list data.
This commit adds function handling in the streaming_body state handlers:
- Added stream_body_fun/3 for HTTP/1.1 connections
- Added stream_body_fun_h3/3 for HTTP/3 QUIC connections
- Both support stateless fun() and stateful {fun(State), State} forms
- Functions are iterated until they return eof or error
Supported function signatures:
- Stateless: fun() -> {ok, Data} | eof | {error, Reason}
- Stateful: fun(State) -> {ok, Data, NewState} | eof | {error, Reason}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream_body_fun/3helper for HTTP/1.1 to iterate over streaming functionsstream_body_fun_h3/3helper for HTTP/3 QUIC connectionsstreaming_bodystate handlers to detect function arguments before callingencode_chunk/1Supported function signatures:
fun() -> {ok, Data} | eof | {error, Reason}fun(State) -> {ok, Data, NewState} | eof | {error, Reason}Fixes #821