refactor: replace QUIC NIF with pure Erlang implementation#827
Merged
refactor: replace QUIC NIF with pure Erlang implementation#827
Conversation
- Remove c_src/ directory (lsquic, BoringSSL, NIF code) - Remove do_cmake.sh and do_quic.sh build scripts - Add hackney_qpack.erl for QPACK header compression - Update hackney_quic.erl to use pure Erlang quic library - Simplify is_available() to always return true - Update documentation to reflect no C dependencies - Remove debug statements from QPACK decoder HTTP/3 now works with zero external dependencies - just rebar3 compile. Tested against cloudflare.com.
The encoder was not embedding the name length prefix in the instruction byte as required by RFC 9204. The literal-with-literal-name format requires the 3-bit name length prefix to be in the instruction byte (0010_H_NNN), not as a separate string header.
- Add quic to plt_extra_apps for dialyzer - Add dialyzer suppression attributes to hackney_quic.erl for warnings caused by incomplete type specs in quic library - Update xref_ignores for quic and hackney_quic/h3 functions
Fixes header protection sampling crash during PTO timeout.
After stream is done, stream_body should return {error, no_stream}.
Check if connection process is alive before calling get_protocol to avoid noproc errors in CI environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hackney_qpack.erlfor QPACK header compression (RFC 9204)hackney_quic.erlto use pure ErlangquiclibraryBenefits
rebar3 compile- no CMake, Go, or C compiler needed