chore: just fmt at root level formats all rust projects (including CI)#32
Closed
chore: just fmt at root level formats all rust projects (including CI)#32
just fmt at root level formats all rust projects (including CI)#32Conversation
matt2e
changed the title
just fmt at root level formats all rust projects (including CI)
wesbillman
previously approved these changes
Feb 11, 2026
Added a fmt command to the root justfile that runs `cargo fmt --all` to format all workspace crates (acp-client, builderbot-actions, summarize). Previously, only the staged/src-tauri crate had formatting commands in its justfile, leaving the shared crates without a convenient formatting option. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Updated the GitHub Actions workflow to format check all Rust projects: - Runs `cargo fmt --all --check` from the root to format workspace crates (acp-client, builderbot-actions, summarize) - Runs `cargo fmt --check` in staged/src-tauri for the excluded crate - Split formatting into a separate step from clippy and check for better clarity Previously, CI only formatted the staged/src-tauri crate, leaving workspace crates unchecked for formatting issues. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Updated staged/justfile fmt and fmt-check commands to format both workspace crates (acp-client, builderbot-actions, summarize) and the excluded staged/src-tauri crate. This ensures running `just fmt` from within the staged directory formats all Rust code in the monorepo, not just the Tauri app. Also simplified CI to match the justfile approach by running the same command sequence. Previously, `just fmt` in the staged directory only formatted staged/src-tauri, leaving workspace crates unformatted. Developers would need to run formatting commands from the root directory to format those crates, which was inconsistent and easy to miss. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Updated CI workflow to run clippy and check for both workspace crates (acp-client, builderbot-actions, summarize) and the excluded staged/src-tauri crate. This ensures all Rust code in the monorepo is linted and type-checked. Previously, CI only ran clippy and check for staged/src-tauri, leaving workspace crates unchecked for warnings and errors. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
matt2e
force-pushed
the
matt2e/crate-fmt
branch
from
d62fb58 to
ec44f07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fmtcommand to root justfile that formats all workspace cratesstaged/justfilefmt commands to format both workspace crates and staged/src-tauriContext
Previously, formatting, linting, and type-checking were inconsistent across the Rust monorepo:
staged/src-taurihad formatting commands in its justfilejust fmtfrom the staged directory only formatted staged/src-tauriChanges
Formatting
fmtcommand that runscargo fmt --allto format workspace cratescargo fmt --all --checkfor workspace crates andcargo fmt --checkin staged/src-tauriLinting and Type-Checking
cargo clippy --allandcargo check --allfor workspace crates, then runs the same commands in staged/src-tauri for the excluded crate🤖 Generated with Claude Code