swidth: use cross platform implementation, fixes #7493#9283
Merged
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom Feb 9, 2026
Merged
swidth: use cross platform implementation, fixes #7493#9283ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9283 +/- ##
==========================================
+ Coverage 75.86% 75.89% +0.03%
==========================================
Files 86 86
Lines 14758 14761 +3
Branches 2195 2198 +3
==========================================
+ Hits 11196 11203 +7
+ Misses 2889 2884 -5
- Partials 673 674 +1 ☔ View full report in Codecov by Sentry. |
48387e0 to
dc65861
Compare
This implementation should be good enough for our usecase (paths) and has no external dependencies. There is also a wcwidth library which might be even better, but would add another dependency.
dc65861 to
37fbe3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation should be good enough for our usecase (paths) and has no external dependencies.
There is also a wcwidth library which might be even better, but would add another dependency.