Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 94.55% 94.73% +0.17%
==========================================
Files 12 12
Lines 147 152 +5
Branches 23 24 +1
==========================================
+ Hits 139 144 +5
Misses 6 6
Partials 2 2 |
- Update test snapshot
Owner
|
Thanks for this awesome work @josephting ! 🎉 I'm in the middle of making a theme to handle multiple sites, so I will hold of this PR for abit to add it to the root theme, so ALL sites can get this feature 👍 Awesome work, thanks very much! |
Author
|
Nice. Feel free to ping me should you need anything from me. 😄 |
Owner
Yeah will do 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3.
It's my first time working with Gatsby so please let me know if you find anything that need changes.
I tried to add pagination with
pagination-ellipsisif number of pages exceeds 7 pages but my JSX experience is lacking as well.Some styles got overwritten (pagination number had bullets) for some reason so I added some styles to fix the pagination layout.
Pagination Preview
