Conversation
|
@yoshuawuyts is this API change a breaking one? It permits more programs to typecheck than previously, and shouldn't break any existing ones. |
36171c5 to
49f2f68
Compare
yoshuawuyts
left a comment
There was a problem hiding this comment.
Removing the 'static bound here is correct and matches other implementations in the ecosystem.
|
Just to provide an update here - a transitive dep upgrade If necessary we can turn off the wstd-aws CI checks that pull in crc-fast as the transitive dep in order to get CI working again, but that hasn't seemed urgent, so I haven't. |
Factor out `spawn` into an unsafe helper `spawn_unchecked` where `block_on` can allow a non-static future and output to execute because dataflow ensures the Task does not outlive the future. Fixes #107
49f2f68 to
d74b757
Compare
Factor out
spawninto an unsafe helperspawn_uncheckedwhereblock_oncan allow a non-static future and output to execute because dataflow ensures the Task does not outlive the future.Fixes #107