Preserve test attributes on generated wrapper function#112
Merged
pchickey merged 1 commit intobytecodealliance:mainfrom Jan 6, 2026
Merged
Preserve test attributes on generated wrapper function#112pchickey merged 1 commit intobytecodealliance:mainfrom
pchickey merged 1 commit intobytecodealliance:mainfrom
Conversation
pchickey
approved these changes
Jan 5, 2026
Contributor
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
From my reading of the tokio::test source code, its behavior is equivalent to this change.
Contributor
|
CI is hosed because of the crc-fast wasm-ld issue, I am working on resolving that now |
Contributor
|
If you rebase on or merge with main, CI should pass. |
Contributor
Author
|
Done, thanks for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111