NFC: simplify internals of http::response::try_from_incoming#115
Merged
NFC: simplify internals of http::response::try_from_incoming#115
Conversation
pchickey
force-pushed
the
pch/simplify_http_response_from_incoming
branch
from
bca8e7e to
be9bc23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change eliminates some error-handling control flow in
try_from_incomingwhich is unreachable, and replaces it withexpect:The
http::response::Builderkeeps internal state of whether the builder has errored, which is only reachable by passingBuilder::headeran erroringTryInto<HeaderName>orTryInto<HeaderValue>. Since theBuilder::headermethod is never used, we knowBuilder::headers_mutwill never give the None case, nor willBuilder::bodygive the error case. So, rather than treat those as control flow, we unwrap if this invariant is ever broken because that would only be possible due to some unrecoverable bug in wstd, rather than incorrect use or invalid input.This is a nonfunctional change and really just serves the next person who has to examine
try_from_incomingand figure out exactly what error case it encountered, and save them reasoning through that those bits of control flow are actually unreachable.