Skip to content

Comments

fix: quicktype dependency ownership#241

Merged
hurali97 merged 1 commit intomainfrom
fix/rearrange-quicktype-deps
Feb 23, 2026
Merged

fix: quicktype dependency ownership#241
hurali97 merged 1 commit intomainfrom
fix/rearrange-quicktype-deps

Conversation

@hurali97
Copy link
Member

Summary

  • Move quicktype-core and quicktype-typescript-input to packages/cli dependencies (actual runtime owner).
  • Remove quicktype-* from packages/brownie dependencies (not directly used there).
  • Move quicktype-* from root dependencies to root devDependencies to avoid implying consumer/runtime ownership at monorepo root.
  • Prevent host-app manual installs by declaring runtime deps where codegen executes.

The quicktype-* are imported by Brownie codegen implementation in @callstack/brownfield-cli (generateSwift / generateKotlin).

When these deps are not declared by CLI, local workspace hoisting can mask the issue, but external consumers may need to install them manually.

This change makes dependency ownership explicit and reliable for published packages.

Test plan

CI passes - 🟢

Verified the changes from this PR and #239 - #240

Screen.Recording.2026-02-23.at.1.16.12.PM.mov

Everything works as expected

Copilot AI review requested due to automatic review settings February 23, 2026 08:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes quicktype-* dependency ownership explicit in the monorepo by moving the runtime dependencies to the actual runtime package (@callstack/brownfield-cli) and removing/relocating them from packages where they’re not directly used.

Changes:

  • Add quicktype-core and quicktype-typescript-input to packages/cli dependencies (runtime owner for codegen).
  • Remove quicktype-* from packages/brownie dependencies (no direct usage).
  • Move quicktype-* from root dependencies to root devDependencies to avoid implying runtime ownership at the repo root.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
yarn.lock Updates lock metadata to reflect the dependency ownership move.
packages/cli/package.json Declares quicktype-* as runtime dependencies where codegen imports occur.
packages/brownie/package.json Removes unused direct quicktype-* dependencies.
package.json Moves quicktype-* to root devDependencies to reflect non-runtime root usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hurali97 hurali97 merged commit 8b99d0b into main Feb 23, 2026
12 of 13 checks passed
@hurali97 hurali97 deleted the fix/rearrange-quicktype-deps branch February 23, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants