docs: mention AppCompatActivity constraint with Expo#245
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds important documentation about a constraint when using Expo brownfield integration with Android. The note clarifies that ComponentActivity cannot be used with Expo apps because Expo requires AppCompatActivity specifically, with a reference to the Expo source code that enforces this requirement.
Changes:
- Adds a documentation note in the Expo integration guide warning developers that
ComponentActivityis incompatible with Expo apps - Provides a direct link to the Expo source code showing the hard type assertion that requires
AppCompatActivity
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a note to the expo docs, stating the constraint to use the
AppCompatActivity. For example, a new bootstrapped project from Android Studio for JetPack compose will contain theComponentActivityand using the generated Expo Brownfield AAR is not possible because Expo needsAppCompatActivityinstead.This only affects the native or host Android Apps, which consumes the AAR.
Test plan
N/A