Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs minor housekeeping in the brownfield Gradle plugin by removing an obsolete Expo artifact blacklist entry and fixing a log message typo to improve readability.
Changes:
- Removed the hardcoded
ExpoAppArtifactMatcherentry from the Expo transitive dependency artifact blacklist. - Fixed a missing whitespace in the “Injecting dependency…” log line when modifying Gradle module metadata.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/shared/Constants.kt |
Removes the obsolete hardcoded ExpoApp artifact blacklist entry. |
gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/expo/ExpoPublishingHelper.kt |
Fixes a log message formatting typo by adding the missing space. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hurali97
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes an obsolete
ArtifactMatcherand fixes a typo in log message in the Gradle plugin.The matcher is obsolete since it uses a hardcoded project group name of
ExpoApp, which may be changed inapp.json; it seems to have always been obsolete since the actual logic that performs the duty agnostically of the project name is present inExpoPublishingHelper::shouldExcludeDependency, which excludes root project dependencies.Test plan