value change does not change StepMarker position#715
Open
wjaszczuk wants to merge 3 commits intocallstack:mainfrom
Open
value change does not change StepMarker position#715wjaszczuk wants to merge 3 commits intocallstack:mainfrom
wjaszczuk wants to merge 3 commits intocallstack:mainfrom
Conversation
added 3 commits
June 10, 2025 14:28
Slider listens to changes on value and set current value, and the StepMarker will be set correctly (if it is set)
Collaborator
|
@wjaszczuk Verified, looks good @BartoszKlonowski I guess we can merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes #712
I've noticed that StepMarker internally uses the
currentValueproperty. This property is set in theonValueChangeEventevent handler, but when the user changes thevalue, the change is not reflected bycurrentValue.I added a
useEffecthook, which listens to changes ofvalueand sets ```currentValue ``.I added a test for that. I ran it before and after the changes were made. It failed without my fix.
I also added
@testing-library/react-native, and I refactored all existing tests to userenderandscreenfrom the mentioned library. The reason for that was a deprecation warning from the react-test-renderercreatefunction (https://react.dev/warnings/react-test-renderer).The snapshots remained the same.
Test Plan:
I added unit tests for the bug. The test failed without my fix.
I tested it manually, using the example application too.
I also provided recordings from tests:
before changes
before_changes.mov
after changes
after_changes.mov