This repository was archived by the owner on Jul 31, 2023. It is now read-only.
override sampling decision#338
Closed
kyessenov wants to merge 1 commit intocensus-instrumentation:masterfrom
Closed
override sampling decision#338kyessenov wants to merge 1 commit intocensus-instrumentation:masterfrom
kyessenov wants to merge 1 commit intocensus-instrumentation:masterfrom
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
cc @objectiser |
Contributor
|
BTW we discussed this in census-instrumentation/opencensus-specs#218 |
g-easy
reviewed
Jul 1, 2019
|
|
||
| bool Span::IsSampled() const { return context_.trace_options().IsSampled(); } | ||
|
|
||
| void Span::StopRecording() { span_impl_ = nullptr; } |
Contributor
There was a problem hiding this comment.
This approach will not work, it prevents Span::End from doing:
exporter::RunningSpanStoreImpl::Get()->RemoveSpan(span_impl_);
(i.e. leaks memory)
Contributor
Author
There was a problem hiding this comment.
Ouch. I was not aware of the mechanics of memory management here
Contributor
There was a problem hiding this comment.
I'm sorry. I wish things were simple.
Contributor
|
How about this approach: #339 @bogdandrutu what do you think? |
Contributor
Author
|
I'm fine with either approach. The health checking trace noise is the most visible impact of not having span abandonment, which should be possible to fix with #339. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients of opencensus may want to delay the sampling decision until after the span has been created.
For example, at the time envoyproxy decides whether a request is a health check or not, it may already have started recording the span:
To support this use case, other tracers expose a
setSamplingoverride. I think it's sufficient to stop recording the span for this case, e.g. only override the sampling decision to false.Signed-off-by: Kuat Yessenov kuat@google.com