Remove custom createLock method in BaseLogHandler#1248
Remove custom createLock method in BaseLogHandler#1248danigm wants to merge 2 commits intocensus-instrumentation:masterfrom
Conversation
This patch removes the override of createLock method so this class will use the default logging.Handler method. The tests are failing for python 3.13 because in this version there's a direct usage of self.lock instead of calling self.acquire(): https://github.com/python/cpython/blob/3.13/Lib/logging/__init__.py#L1025-L1026
danigm
requested review from
a team,
aabmass,
hectorhdzg,
jeremydvoss and
lzchen
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
To keep the current behaviour (of not synchronising handling), you instead may want to set |
This patch adds a DummyLock to do not synchronising handling, as suggested in the comment: census-instrumentation#1248 (comment)
|
👍 We were affected by this, causing tests to fail at Python 3.13. I tried to add these changes to the package directly in the project, and then things works again. Any idea of when this will be officially released in the public package? |
3 participants
This patch removes the override of createLock method so this class will use the default logging.Handler method.
The tests are failing for python 3.13 because in this version there's a direct usage of self.lock instead of calling self.acquire(): https://github.com/python/cpython/blob/3.13/Lib/logging/__init__.py#L1025-L1026