Record audit entry when API tokens are auto-revoked#2759
Merged
migmartri merged 1 commit intochainloop-dev:mainfrom Feb 19, 2026
Merged
Record audit entry when API tokens are auto-revoked#2759migmartri merged 1 commit intochainloop-dev:mainfrom
migmartri merged 1 commit intochainloop-dev:mainfrom
Conversation
Allow APITokenRevoked audit events to be recorded when tokens are automatically revoked due to inactivity. Override RequiresActor() to return false on APITokenRevoked, following the pattern used by CASBackendStatusChanged. This enables the audit trail to capture auto-revocations with the system actor (system@chainloop.dev) rather than silently dropping the event. Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
jiparis
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the APITokenStaleRevoker background service auto-revokes inactive API tokens, no audit entry was recorded. The revoke flow already dispatches an APITokenRevoked audit event, but it was silently dropped because APITokenRevoked inherited RequiresActor() → true from APITokenBase, and the stale revoker runs without a user or API token in context.
This fix overrides RequiresActor() on APITokenRevoked to return false, following the existing pattern used by CASBackendStatusChanged for system-generated events. Manual revocations continue to record the user actor, while auto-revocations now record the system actor (system@chainloop.dev).
Closes #2758