Added C++ smoketest for quickstart-chat + updated chat doc#4109
Merged
JasonAtClockwork merged 7 commits intomasterfrom Feb 12, 2026
Merged
Added C++ smoketest for quickstart-chat + updated chat doc#4109JasonAtClockwork merged 7 commits intomasterfrom
JasonAtClockwork merged 7 commits intomasterfrom
Conversation
JasonAtClockwork
added
the
documentation
rekhoff
approved these changes
Feb 9, 2026
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
Doc changes look good. No issues found with the changes in the workflow or tests. Provided all CI pass after these changes, I approve.
JasonAtClockwork
force-pushed
the
jlarabie/cpp-quickstart
branch
from
3099995 to
0d33e9e
Compare
JasonAtClockwork
requested review from
bfops and
cloutiertyler
as code owners
JasonAtClockwork
changed the base branch from
jlarabie/bindings-cpp
to
master
bfops
approved these changes
Feb 11, 2026
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
changes to ci.yml make me sad for complexity reasons but LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
API and ABI breaking changes
N/A
Expected complexity level and risk
1 - Small changes to get the C++ modules to be tested through quickstart
Testing