[Workers] Add Error 501 Not Implemented documentation#28574
[Workers] Add Error 501 Not Implemented documentation#28574caley-b merged 4 commits intocloudflare:productionfrom
Conversation
|
/bonk review and suggest any fixes |
There was a problem hiding this comment.
Overall this is a clean, well-structured addition that follows the existing patterns for 5xx error pages. A few things to address:
- Missing trailing newline — the file ends without a final newline character, which will cause the
No newline at end of filediff marker. Most editors and linters expect a trailing newline. - Style guide:
e.g.→for example— the Cloudflare style guide explicitly says "Do not use i.e. or e.g. Instead, use that is or for example, respectively." The rest of the 5xx error pages consistently use "for example" rather than "e.g.". - Scope accuracy — the description says Cloudflare returns 501 when a request uses an unsupported HTTP method on the Workers Runtime. It may be worth confirming whether this applies only to Workers routes or also to other Cloudflare proxy scenarios. If it is truly Workers-specific, consider noting that in the page (similar to how error-500.mdx has a "Workers-specific causes" section).
src/content/docs/support/troubleshooting/http-status-codes/cloudflare-5xx-errors/error-501.mdx
Show resolved
Hide resolved
src/content/docs/support/troubleshooting/http-status-codes/cloudflare-5xx-errors/error-501.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/support/troubleshooting/http-status-codes/cloudflare-5xx-errors/error-501.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/support/troubleshooting/http-status-codes/cloudflare-5xx-errors/error-501.mdx
Outdated
Show resolved
Hide resolved
|
Review submitted. Here's a summary of the feedback I left on the PR: 4 inline comments posted:
|
…udflare-5xx-errors/error-501.mdx Fix for style guide violation. Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
…udflare-5xx-errors/error-501.mdx Using RFC direct link for defined HTTP methods. Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
Summary
[SPM-3086] Add documentation for HTTP Error 501 (Not Implemented) to the Cloudflare 5xx errors section.
Screenshots (optional)
Documentation checklist