Skip to content

[Workers] Add Error 501 Not Implemented documentation#28574

Merged
caley-b merged 4 commits intocloudflare:productionfrom
krys-cf:spm-3086/error-501-not-implemented
Feb 25, 2026
Merged

[Workers] Add Error 501 Not Implemented documentation#28574
caley-b merged 4 commits intocloudflare:productionfrom
krys-cf:spm-3086/error-501-not-implemented

Conversation

@krys-cf
Copy link
Contributor

@krys-cf krys-cf commented Feb 24, 2026

Summary

[SPM-3086] Add documentation for HTTP Error 501 (Not Implemented) to the Cloudflare 5xx errors section.

Screenshots (optional)

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The change adheres to the documentation style guide.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@elithrar
Copy link
Collaborator

/bonk review and suggest any fixes

Copy link
Contributor

@ask-bonk ask-bonk bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a clean, well-structured addition that follows the existing patterns for 5xx error pages. A few things to address:

  1. Missing trailing newline — the file ends without a final newline character, which will cause the No newline at end of file diff marker. Most editors and linters expect a trailing newline.
  2. Style guide: e.g.for example — the Cloudflare style guide explicitly says "Do not use i.e. or e.g. Instead, use that is or for example, respectively." The rest of the 5xx error pages consistently use "for example" rather than "e.g.".
  3. Scope accuracy — the description says Cloudflare returns 501 when a request uses an unsupported HTTP method on the Workers Runtime. It may be worth confirming whether this applies only to Workers routes or also to other Cloudflare proxy scenarios. If it is truly Workers-specific, consider noting that in the page (similar to how error-500.mdx has a "Workers-specific causes" section).

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Feb 25, 2026

Review submitted. Here's a summary of the feedback I left on the PR:

4 inline comments posted:

  1. Missing trailing newline (line 18) — The file lacks a final newline character. Suggested fix provided.

  2. Style guide violation: e.g.for example (line 14) — The Cloudflare style guide explicitly prohibits Latin abbreviations like e.g. in favor of "for example". All other 5xx error pages in this directory use "for example". Suggestion provided.

  3. Minor: etc. in method list (line 13) — Optional suggestion to link to RFC 9110 instead of using an imprecise etc. trailing list, though the current wording is acceptable.

  4. Scope question (line 9) — Asked the author to confirm whether the 501 response is exclusively from the Workers Runtime or if Cloudflare's proxy layer can also return it in other scenarios. If it's Workers-only, the page structure could better reflect that (similar to how error-500.mdx separates general vs. Workers-specific causes).

github run

krys-cf and others added 3 commits February 25, 2026 09:25
…udflare-5xx-errors/error-501.mdx


Fix for style guide violation.

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
…udflare-5xx-errors/error-501.mdx


Using RFC direct link for defined HTTP methods.

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
@krys-cf krys-cf marked this pull request as ready for review February 25, 2026 16:50
@krys-cf krys-cf requested review from a team as code owners February 25, 2026 16:50
@caley-b caley-b merged commit 87b38ca into cloudflare:production Feb 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants