fix(ci): enable ICMP tests on Linux and fix gotestfmt on macOS/Windows#1602
Open
mannie-exe wants to merge 1 commit intocloudflare:masterfrom
Open
fix(ci): enable ICMP tests on Linux and fix gotestfmt on macOS/Windows#1602mannie-exe wants to merge 1 commit intocloudflare:masterfrom
mannie-exe wants to merge 1 commit intocloudflare:masterfrom
Conversation
mannie-exe
changed the title
Three pre-existing issues prevented the Check workflow from passing: 1. Linux: ICMP tests fail because ping_group_range on GitHub Actions runners defaults to "1 0" (unprivileged ICMP disabled). Add sysctl step to allow unprivileged ICMP sockets. 2. macOS: go test -json emits linker warnings (LC_DYSYMTAB) as "Action":"build-output" JSON lines. gotestfmt v2.5.0 predates this action type (Go 1.21+) and panics in parseLine (GoTestTools/gotestfmt#64). Filter build-output lines before piping to gotestfmt. 3. Windows: GO_TEST_LOG_OUTPUT pointed to /tmp/gotest.log which does not resolve through the MSYS2-to-native-Go boundary. Use relative path instead. These failures were masked by fail-fast: Linux failed first (ICMP), cancelling macOS and Windows before they reached gotestfmt.
mannie-exe
force-pushed
the
fix/ci-workflow
branch
from
3ccb358 to
556d6ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I didn't see any issues for the CI/CD failures, so I'm not really sure if this is needed work, but I did get them working on my fork and wanted to share in case it's needed.