Modify calculate response size logic for mongoengine queryset#172
Merged
ImMin5 merged 2 commits intocloudforet-io:masterfrom Apr 15, 2025
Merged
Modify calculate response size logic for mongoengine queryset#172ImMin5 merged 2 commits intocloudforet-io:masterfrom
ImMin5 merged 2 commits intocloudforet-io:masterfrom
Conversation
Signed-off-by: ImMin5 <mino@megazone.com>
Signed-off-by: Jongmin Kim <whdalsrnt@megazone.com>
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/spaceone/core/service/init.py:277
- Ensure the tuple is not empty before accessing its first element to avoid an IndexError. Consider adding a check for tuple length.
if isinstance(response_or_iterator, tuple):
| self._request_map = request_map | ||
| self._channel_key = channel_key | ||
| self.metadata = options.get("metadata", {}) | ||
| self.timeout = timeout or 60 |
There was a problem hiding this comment.
If timeout is explicitly set to 0, this expression defaults to 60 due to the falsy check; consider using an explicit check against None to allow valid zero timeouts.
Suggested change
| self.timeout = timeout or 60 | |
| self.timeout = 60 if timeout is None else timeout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Description
Known issue