Update Dockerfile to use Python 3.10 and improve build process#173
Merged
ImMin5 merged 1 commit intocloudforet-io:masterfrom Apr 30, 2025
Merged
Update Dockerfile to use Python 3.10 and improve build process#173ImMin5 merged 1 commit intocloudforet-io:masterfrom
ImMin5 merged 1 commit intocloudforet-io:masterfrom
Conversation
Signed-off-by: ImMin5 <mino@megazone.com>
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Dockerfile to use Python 3.10 and improves the build process by switching from a PyPI-based installation of spaceone-core to a local source installation with version injection via setup.py.
- Upgraded Python version from 3.8 to 3.10
- Replaced the PyPI spaceone-core install mechanism with a local source installation method
Files not reviewed (1)
- Dockerfile: Language not supported
Comments suppressed due to low confidence (1)
pkg/pip_requirements.txt:34
- Ensure that removing 'spaceone-core' from the pip_requirements.txt aligns with the local installation process in setup.py, and that any necessary version management is handled appropriately there.
-spaceone-core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Description
3.8->3.10Known issue
3.11soon.