-
Notifications
You must be signed in to change notification settings - Fork 19
fix: local registry on a custom port #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
BUILD.md
Outdated
| > Kubernetes at `registry.extensions:5000`. When testing your local builds, you | ||
| > must point the extension's `reference` to this internal address. | ||
| > By default, the local registry running alongside the Kind cluster is | ||
| > reachable within Kubernetes at `registry.extensions:5000`. When testing your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be registry.pg-extensions, right?
| > reachable within Kubernetes at `registry.extensions:5000`. When testing your | |
| > reachable within Kubernetes at `registry.pg-extensions:5000`. When testing your |
See
| REGISTRY_NAME: registry.pg-extensions |
BUILD.md
Outdated
| > Kubernetes at `registry.extensions:5000`. When testing your local builds, you | ||
| > must point the extension's `reference` to this internal address. | ||
| > By default, the local registry running alongside the Kind cluster is | ||
| > reachable within Kubernetes at `registry.extensions:5000`. When testing your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #102
mbiagetti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Approved with minor fix, see #102
docs: review Signed-off-by: Matteo <matteo.biagetti@enterprisedb.com>
Closes #36