Skip to content

Cypress tests #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lumburovskalina wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Cypress tests #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions components/KernDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export default function KernDropdown(props: KernDropdownProps) {
aria-hidden="true"
/>
</div> : <>
{props.hasButtonDots ? (<Menu.Button onClick={toggleDropdown} className="group relative inline-flex h-8 w-8 items-center justify-center rounded-full">
{props.hasButtonDots ? (<Menu.Button onClick={toggleDropdown} className="group relative inline-flex h-8 w-8 items-center justify-center rounded-full" {...(props.buttonDataCy && { 'data-cy': props.buttonDataCy })}>
<span className="flex h-full w-full items-center justify-center rounded-full">
<MemoIconDotsVertical
size={24}
Expand All @@ -214,7 +214,8 @@ export default function KernDropdown(props: KernDropdownProps) {
</Menu.Button>
) : (<Menu.Button onClick={toggleDropdown} className={`inline-flex w-full justify-between items-center rounded-md border border-gray-300 px-4 py-2 text-sm font-semibold text-gray-700 shadow-sm focus:outline-none focus:ring-2
focus:ring-gray-300 focus:ring-offset-2 focus:ring-offset-gray-100 disabled:opacity-50 disabled:cursor-not-allowed ${props.buttonClasses ?? ''} ${props.buttonCaptionBgColor ?? 'bg-white hover:bg-gray-50'}`}
disabled={isDisabled}>
disabled={isDisabled}
{...(props.buttonDataCy && { 'data-cy': props.buttonDataCy })}>
<div className={`flex items-center gap-x-1 ${props.truncateButtonName ? 'max-w-[300px] truncate' : ''}`}>
{props.buttonPrefixIcon}
{!props.hasCheckboxesThreeStates && props.buttonName}
Expand Down Expand Up @@ -250,6 +251,7 @@ export default function KernDropdown(props: KernDropdownProps) {
<div className='w-full'>
<Tooltip content={props.tooltipsArray && props.tooltipsArray[index]} placement={props.tooltipArrayPlacement ?? 'left'} color="invert" style={{ width: '100%' }} className={disabledOptions[index] ? 'pointer-events-none' : ''}>
<label htmlFor="option"
{...(props.optionDataCy && props.optionDataCy[index] && { 'data-cy': props.optionDataCy[index] })}
className={combineClassNames(
disabledOptions[index] ? "opacity-50 cursor-not-allowed" : "opacity-100 cursor-pointer",
backgroundColors[index], props.useDifferentTextColor && props.useDifferentTextColor[index] ? 'text-' + props.differentTextColor + '-700' : active && !backgroundColors[index] ? "bg-gray-100 text-gray-900" : "text-gray-700",
Expand Down
5 changes: 4 additions & 1 deletion components/kern-button/KernButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ interface KernButtonProps {
confirm?: boolean;
className?: string;
asDiv?: boolean;
/** Optional data-testid for E2E tests */
dataTestId?: string;
}

export default function KernButton(props: KernButtonProps) {
Expand Down Expand Up @@ -69,7 +71,8 @@ export default function KernButton(props: KernButtonProps) {
className: buttonClasses,
ref: props.innerRef,
disabled: props.disabled,
type: props.type || 'submit'
type: props.type || 'submit',
...(props.dataTestId && { 'data-testid': props.dataTestId }),
}

const children = <Tooltip className={"flex gap-x-2 items-center " + (props.disabled ? "cursor-not-allowed" : "")} color="invert" content={props.tooltip} placement={props.tooltipPlacement || "bottom"} >
Expand Down
4 changes: 4 additions & 0 deletions types/dropdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ export type KernDropdownProps = {
forceOverwriteOpen?: boolean;
truncateButtonName?: boolean;
placeholder?: string;
/** Optional data-cy for the trigger button (e.g. for E2E tests). */
buttonDataCy?: string;
/** Optional data-cy for each option (same order as options; e.g. for E2E tests). */
optionDataCy?: string[];
}

export type AppSelectionDropdownProps = {
Expand Down