feat: implement scoreTargets configuration for all plugins#1099
Merged
hanna-skryl merged 16 commits intomainfrom Sep 3, 2025
Merged
feat: implement scoreTargets configuration for all plugins#1099hanna-skryl merged 16 commits intomainfrom
hanna-skryl merged 16 commits intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 4afb131
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/create-cli
@code-pushup/core
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 58583f9 with previous commit b05dd6e. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 2 audits improved, 👎 6 audits regressed, 14 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
588 other audits are unchanged. |
BioPhoton
reviewed
Sep 2, 2025
BioPhoton
requested changes
Sep 2, 2025
BioPhoton
previously approved these changes
Sep 3, 2025
Collaborator
BioPhoton
left a comment
There was a problem hiding this comment.
Thx for adjusting the mock code!
matejchalk
requested changes
Sep 3, 2025
packages/plugin-typescript/src/lib/typescript-plugin.unit.test.ts
Outdated
Show resolved
Hide resolved
matejchalk
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #713 closes #721
This PR finalizes
scoreTarget/scoreTargetsfeature implementation, allowing users to configure threshold values for audits across all plugins.Changes
perfectScoreThresholdwithscoreTargetsin the coverage pluginscoreTargetssupport to all plugins: ESLint, Lighthouse, JS Packages, TypeScript, and JSDocBreaking change
Coverage plugin:
perfectScoreThreshold→scoreTargetsUsage