build(models): run prettier immediately after zod2md docs generation#1123
Merged
matejchalk merged 1 commit intomainfrom Sep 26, 2025
Merged
build(models): run prettier immediately after zod2md docs generation#1123matejchalk merged 1 commit intomainfrom
matejchalk merged 1 commit intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 796e9d9
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Contributor
Code PushUp😟 Code PushUp report has regressed – compared current commit 8f32f5e with previous commit 38b04e4. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 3 groups regressed, 👎 5 audits regressed, 13 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
592 other audits are unchanged. |
vmasek
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a slightly annoying local development problem.
The
models:generate-docstarget is being run automatically for eachmodels:build, which is fairly frequent because other tasks often depend onbuild(e.g.e2e-test, or recentlylint). This itself is fine, but because the Markdown generated byzod2mdis 100% the same as how Prettier would format it, you often end up having a local change tomodels-reference.md. It disappears once you commit, because ourpre-commithook formats files withprettier, which effectively reverts the file changes. So it's not a big deal, but it still happens often enough to be a nuisance.I've tweaked the
generate-docstarget to runprettierimmediately afterzod2md, so there are no intermediate file changes anymore. 😌