refactor: fix cache invalidation for tests in monorepo setups#1142
Merged
refactor: fix cache invalidation for tests in monorepo setups#1142
Conversation
|
View your CI Pipeline Execution ↗ for commit 6dff5a7
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/coverage-plugin
@code-pushup/nx-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 0d82b87 with previous commit 9876d94. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 3 groups improved, 👍 8 audits improved, 👎 1 audit regressed, 12 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
589 other audits are unchanged. |
matejchalk
reviewed
Nov 10, 2025
9 tasks
matejchalk
reviewed
Nov 10, 2025
Collaborator
matejchalk
left a comment
There was a problem hiding this comment.
I tried replicating the cache bug in plugin-eslint as described in #1102, and it now works as I would expect. 🎉
I left some suggestions for improving the setup tests.
Don't forget to update the PR description, now that you've covered plugin-eslint, I believe this PR can close the issue without a follow-up PR (closes #1102).
testing/test-utils/src/lib/utils/test-folder-setup.unit.test.ts
Outdated
Show resolved
Hide resolved
testing/test-utils/src/lib/utils/test-folder-setup.unit.test.ts
Outdated
Show resolved
Hide resolved
matejchalk
approved these changes
Nov 10, 2025
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
approved these changes
Nov 10, 2025
This was referenced Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove folders from
.nxignoreand rename files to not get detected by NxFollowup PR:one last folder is remaining underpackages/plugin-eslint/mocks/fixtures/nx-monorepocloses #1102