Conversation
no issue - Removed dead Ember analytics components (`Posts::Analytics`, `Posts::OldAnalytics`, `Posts::PostActivityFeed`, `Posts::LinksTable`, `Posts::FeedbackEventsChart`, `MemberAttribution::SourceAttributionTable/Chart`) - Removed the orphaned Ember route, controller, and template for `posts/analytics` (the route was already removed from the router in favor of the React `posts-x` route) - Removed ~3,750 lines of dead CSS (`gh-links-list`, `gh-post-analytics-box/item/resource/split/mentions`, `gh-post-activity-feed`, `gh-feedback-events`, `feature-trafficAnalytics` styles) - Removed associated unit and integration tests for deleted components
no issue - Removed the `audienceFeedback` labs flag that was already in the `GA_FEATURES` list - Audience feedback functionality (newsletter feedback, feedback events, feedback API endpoint) is now unconditionally enabled
ref https://linear.app/ghost/issue/BER-3275 The banner that highlights an active theme with errors was missing in the React sidebar. - added hook for reading errors from active theme - added missing banner and errors/warnings list modal Note: The modal duplicates some UI from `admin-x-settings` but we don't yet have any patterns for sharing components across apps or the Shade / Admin-X-Design-System boundary --- To test this PR, upload and activate the zip for an old Casper version (https://github.com/TryGhost/Casper/releases/tag/v4.4.0) - that will show errors in the theme upload modal and when activated show the sidebar banner. The sidebar banner can be clicked to show the list of theme errors, this is a duplicate of the theme upload modal's list but re-implemented with Shade components. --------- Co-authored-by: Weyland Swart <weyland.swart@gmail.com> Co-authored-by: Peter Zimon <zimo@ghost.org>
no refs. - Left a comment in code which shows theme errors for all sites
ref https://linear.app/ghost/issue/BER-3286/ - Admin's nav has been fully migrated from Ember to React so we no longer need related code and styles on the Ember side
ref https://linear.app/ghost/issue/DES-1284/tab-alignment-is-off-in-settings-safari ref https://linear.app/ghost/issue/DES-1285/toggle-alignment-is-off-in-analytics-setting - Added align prop to the Toggle component with `flex-start` being the default - Used center alignment for toggles in Analytics settings as it makes the alignment more balanced - Fixed tab border alignment in Safari by replacing border-b with a pseudo-element and using relative positioning on tab buttons <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Purely presentational CSS/className changes and a small new `Toggle` prop; low risk aside from potential minor layout regressions in other toggle/tab usages. > > **Overview** > Fixes alignment issues in admin settings by updating the design system `Toggle` to support an `align` prop (defaulting to `start`) that controls flex alignment and conditional label offsets. > > Updates the analytics settings toggles to use `align='center'` and move vertical padding to `containerClasses`, keeping switch and label text aligned. > > Adjusts the design system tabs styling to avoid Safari border misalignment by switching the tab-list divider to a pseudo-element (`after`) and making tab triggers `relative`/layered; also removes an unnecessary wrapper around each `TabButton`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 93dbd15. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )