Conversation
…ramework (#43138) # Why The hrems XCFramework names has been updated to `hermesvm.xcframework` but the CLI still copies it under `hermes.xcframework` # How Updated the name to `hermesvm.xcframework` to match the new name # Test Plan - E2E tests for CLI on the CI - Tested manually verifying compilation and name of the XCFramework # Checklist - [X] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [X] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
# Why Commit 68f6c1a changed @expo/config's evalConfig to use loadModuleSync from @expo/require-utils, which calls Node's native `require()` instead of `fs.readFileSync`. Since `require()` bypasses memfs, the 5 tests that create dynamic `app.config.js` files via vol.writeFileSync broke — the config loaded as null. Added `jest.doMock('/app/app.config.js', factory, { virtual: true })` after each vol.writeFileSync call — this registers the config as a virtual Jest module so require() can find it. Why both vol.writeFileSync and jest.doMock are needed: @expo/config uses fs.existsSync to discover config files before loading them. The memfs write satisfies file detection; the Jest mock satisfies require() loading. # How - update tests # Test Plan - green CI # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )