Conversation
…on (#43202) # Why Setting `gestureEnabled` had no effect when used with zoom transition **Before** https://github.com/user-attachments/assets/db45a5f4-11ac-463a-a6fc-22c25108fbf3 ** After** https://github.com/user-attachments/assets/2f5685e3-3ed2-44f0-8e0b-4ba6a2b5545f # How When `gesturesEnabled` are set to `false` then pass `{maxX:0,maxY:0}` to `dismissalBoundsRect`. The `maxX:0, maxY:0` means that the dismiss can start at coordinates that are smaller then `0,0`, which effectively block the dismissal. # Test Plan 1. Unit tests 2. Manual testing # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why The issue is mentioned in this PR - #43140 Currently, `foregroundStyle(.primary)`, `foregroundStyle(.secondary)` etc hierarchical styles are not working with `Text`. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How - Pass `hierarchicalStyle` param instead of passing `style` to native. - Moved foreground style to a separate file. <!-- How did you build this feature or fix this bug and why? --> # Test Plan Added example in NCL <img width="333" height="259" alt="Screenshot 2026-02-18 at 11 51 18 AM" src="https://github.com/user-attachments/assets/a27184b0-f68a-4dae-b258-826391cf1cc0" /> <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why Adds support for creating audio playlists. # How Introduce a new shared object type `AudioPlaylist` using `AVQueuePlayer` Add a new screen to NCL. # Test Plan Bare expo
# Why Adds support for creating audio playlists on android # How Introduce a new shared object type `AudioPlaylist`. Exoplayer already has good support for playlists we just need to use the relevant methods. # Test Plan Bare expo
# Why Adds support for creating audio playlists on web # How Introduce a new shared object type `AudioPlaylist`. # Test Plan Bare expo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )