Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions src/jsx/dom/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -657,6 +657,79 @@ describe('DOM', () => {
expect(root.innerHTML).toBe('<div><span>1</span><span>2</span></div>')
})

it('empty array and non-empty array', async () => {
const App = () => (
<div>
{[]}
{[<span>1</span>]}
</div>
)
render(<App />, root)
expect(root.innerHTML).toBe('<div><span>1</span></div>')
})

it('nested array', async () => {
const nestedChildren: Child = [[[<span>1</span>], <span>2</span>]]
const App = () => <div>{nestedChildren}</div>
render(<App />, root)
expect(root.innerHTML).toBe('<div><span>1</span><span>2</span></div>')
})

it('sparse array with nested child', async () => {
const sparseChildren: Child[] = []
sparseChildren[1] = [<span>1</span>]
const App = () => <div>{sparseChildren}</div>
render(<App />, root)
expect(root.innerHTML).toBe('<div><span>1</span></div>')
})

it('toggle empty array and non-empty array on update', async () => {
let setVisible: (value: boolean) => void = () => {}
const App = () => {
const [visible, _setVisible] = useState(false)
setVisible = _setVisible
return (
<div>
{visible ? [] : [<span key='a'>A</span>]}
{visible ? [<span key='b'>B</span>] : []}
</div>
)
}
render(<App />, root)
expect(root.innerHTML).toBe('<div><span>A</span></div>')

setVisible(true)
await Promise.resolve()
expect(root.innerHTML).toBe('<div><span>B</span></div>')

setVisible(false)
await Promise.resolve()
expect(root.innerHTML).toBe('<div><span>A</span></div>')
})

it('reshape nested array on update', async () => {
let setPattern: (value: number) => void = () => {}
const App = () => {
const [pattern, _setPattern] = useState(0)
setPattern = _setPattern
const children: Child =
pattern === 0
? [[<span key='a'>A</span>], <span key='b'>B</span>]
: [<span key='a'>A</span>, [<span key='b'>B</span>]]
return <div>{children}</div>
}
render(<App />, root)
expect(root.innerHTML).toBe('<div><span>A</span><span>B</span></div>')

setPattern(1)
await Promise.resolve()
expect(root.innerHTML).toBe('<div><span>A</span><span>B</span></div>')

setPattern(0)
await Promise.resolve()
expect(root.innerHTML).toBe('<div><span>A</span><span>B</span></div>')
})

it('use the same children multiple times', async () => {
const MultiChildren = ({ children }: { children: Child }) => (
<>
Expand Down
4 changes: 3 additions & 1 deletion src/jsx/dom/render.ts
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,9 @@ export const build = (context: Context, node: NodeObject, children?: Child[]): v
let prevNode: Node | undefined
for (let i = 0; i < children.length; i++) {
if (Array.isArray(children[i])) {
children.splice(i, 1, ...(children[i] as Child[]).flat())
children.splice(i, 1, ...((children[i] as unknown[]).flat(Infinity) as Child[]))
i--
continue
}
let child = buildNode(children[i])
if (child) {
Expand Down
Loading