Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions src/client/client.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,42 @@ describe('Form - Multiple Values', () => {
})
})

describe('Form - Undefined Values', () => {
const server = setupServer(
http.post('http://localhost/form-undefined', async ({ request }) => {
const data = await request.formData()
return HttpResponse.json({
keys: [...data.keys()],
title: data.get('title'),
optional: data.get('optional'),
})
})
)

beforeAll(() => server.listen())
afterEach(() => server.resetHandlers())
afterAll(() => server.close())

const client = hc('http://localhost/')

it('Should skip undefined values in form data', async () => {
// @ts-expect-error `client['form-undefined'].$post` is not typed
const res = await client['form-undefined'].$post({
form: {
title: 'Hello',
optional: undefined,
},
})
expect(res.status).toBe(200)
const json = await res.json()
expect(json).toEqual({
keys: ['title'],
title: 'Hello',
optional: null,
})
})
})

describe('Infer the response/request type', () => {
const app = new Hono()
const route = app.get(
Expand Down
3 changes: 3 additions & 0 deletions src/client/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ class ClientRequestImpl {
if (args.form) {
const form = new FormData()
for (const [k, v] of Object.entries(args.form)) {
if (v === undefined) {
continue
}
if (Array.isArray(v)) {
for (const v2 of v) {
form.append(k, v2)
Expand Down
Loading