Skip to content

Remove rails4-autocomplete and jquery-ui-rails#2467

Merged
olleolleolle merged 4 commits intocodebar:masterfrom
mroderick:issue-2445
Feb 9, 2026
Merged

Remove rails4-autocomplete and jquery-ui-rails#2467
olleolleolle merged 4 commits intocodebar:masterfrom
mroderick:issue-2445

Conversation

@mroderick
Copy link
Collaborator

@mroderick mroderick commented Feb 8, 2026

This has been branched from #2464. Please review that one first

Summary

Removes rails4-autocomplete and jquery-ui-rails gems. Both have been non-functional since April 2022.

Closes #2445

Background

The autocomplete feature was added in September 2015 to suggest existing skills when coaches edited their profiles. During the Bootstrap 5 migration in April 2022 (PR #1745), the form was rewritten and lost the autocomplete parameters. The feature has been broken for nearly 3 years without user complaints.

Why These Removals Are Safe

rails4-autocomplete

  • Last updated: April 2014 (12 years ago)
  • Status: Unmaintained, designed for Rails 4.x
  • Current Rails: 8.1.2
  • Broken since: April 2022 (Bootstrap 5 migration)
  • User impact: Zero complaints in 3 years

jquery-ui-rails

  • Added: September 2015, same commit as rails4-autocomplete
  • Purpose: Single-purpose dependency for autocomplete only
  • Usage verified: Zero jQuery UI methods or classes found in codebase
  • Alternatives present: App uses pickadate-rails, chosen-rails, Bootstrap 5

Verification

Comprehensive codebase analysis confirms zero usage:

  • ✅ No jQuery UI JavaScript methods (.datepicker(), .autocomplete(), .sortable(), etc.)
  • ✅ No jQuery UI CSS classes (ui-widget, ui-state-*, etc.)
  • ✅ No autocomplete data attributes or helpers in views
  • ✅ No test coverage for autocomplete functionality
  • ✅ skill_list field works with manual comma-separated entry

See docs/rails4-autocomplete-investigation.md for full analysis.

Changes

Removed:

  • rails4-autocomplete gem from Gemfile
  • jquery-ui-rails gem from Gemfile
  • Controller autocomplete declaration (app/controllers/members_controller.rb:8)
  • Autocomplete route (config/routes.rb:29)
  • JavaScript requires (//= require autocomplete-rails, //= require jquery-ui)
  • CSS require (*= require jquery-ui)

Preserved:

  • acts-as-taggable-on gem (still used for tagging)
  • skill_list field in member form (works with manual entry)
  • All member model skill methods

Bundle size: Saves ~120KB in production assets

Testing

The skill_list field continues to work as a plain text input accepting comma-separated values. No functionality is lost because the autocomplete feature has been broken since 2022.

Documentation

Full investigation and analysis documented in:

  • docs/rails4-autocomplete-investigation.md

This includes:

  • Complete timeline of the feature (added 2015, broken 2022)
  • Git commit analysis showing when and how it broke
  • Evidence of zero usage across the codebase
  • jquery-ui-rails dependency analysis

Documents the complete history and current state of the rails4-autocomplete
gem, which has been non-functional since April 2022.

Key findings:
- Autocomplete was added in September 2015 and worked correctly
- Accidentally broken during Bootstrap 5 migration in April 2022 (PR codebar#1745)
- All infrastructure (gem, routes, controller code) remains but is unused
- Broken for nearly 3 years with no user complaints
- Gem last updated April 2014 (12 years ago, unmaintained)

Recommendation: Complete removal of the feature and all related code.

Related: codebar#2445
Removes rails4-autocomplete (12+ years unmaintained) and jquery-ui-rails
dependencies that have been non-functional since April 2022.

The autocomplete feature for the skill_list field was accidentally broken
during Bootstrap 5 migration (PR codebar#1745) and has remained broken for nearly
3 years without user complaints.

Analysis confirmed:
- Feature broken since April 2022 (Bootstrap 5 migration)
- Zero usage of jQuery UI widgets across entire codebase
- Both gems added together in 2015 exclusively for autocomplete
- No test coverage for autocomplete functionality
- skill_list field continues working with manual comma-separated entry

Removes:
- rails4-autocomplete gem (last updated April 2014)
- jquery-ui-rails gem (single-purpose dependency)
- Controller autocomplete declaration
- Autocomplete route endpoint
- JavaScript and CSS requires

Bundle size savings: ~120KB

Closes codebar#2445

Documentation: docs/rails4-autocomplete-investigation.md
@mroderick mroderick marked this pull request as ready for review February 8, 2026 21:25
olleolleolle and others added 2 commits February 9, 2026 05:50
Until we have a removal with no issues, we keep this dependency explicit, with a clear sign-post about when we can remove it.
Copy link
Collaborator

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simplifies the frontend story, and avoids having dead code.

@olleolleolle olleolleolle merged commit 871dd25 into codebar:master Feb 9, 2026
8 checks passed
@mroderick mroderick deleted the issue-2445 branch February 9, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rails4-autocomplete removal or refactor

2 participants