Open
Conversation
b8de826 to
b0c1c84
Compare
codedstructure
requested changes
Aug 6, 2025
Owner
codedstructure
left a comment
There was a problem hiding this comment.
In testing, inline code format doesn't work fully, e.g. md="test `a*` test" should show a* in monospace, but doesn't. Try testing against the github comment preview window!
The markdown parsing / splitting should be extracted to a separate markdown.rs file.
Owner
codedstructure
left a comment
There was a problem hiding this comment.
I think a basic example in examples/markdown.xml would be useful, even something as simple as the following, though multiple lines etc would be better.
<svg>
<rect wh="50 10" md="**Hello** _Markdown_ `world`!"/>
</svg>
44c23aa to
085c14f
Compare
codedstructure
requested changes
Aug 18, 2025
…e 1 space from start and end and added example
024c71a to
3d884bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added inline markdown like ability to add italics bold and monospaced (via */_, **/__, `) through the new md attribute instead of the text attribute.