fix: include module-level variables and second-degree helpers in testgen helper FQNs#1540
Merged
fix: include module-level variables and second-degree helpers in testgen helper FQNs#1540
Conversation
…gen helper FQNs Generated tests were importing symbols like _EXTENSION_REGISTRY from the wrong module because helper_function_names only contained first-degree function/class helpers. The AI had no metadata about where module-level variables lived, causing incorrect import paths and 0% test coverage.
Contributor
PR Review SummaryPrek ChecksAll checks passed. No formatting or linting issues found. MypyNo new type errors introduced by this PR. All mypy errors in the changed files are pre-existing. Code ReviewNo critical issues found. The changes are well-structured:
Test Coverage
Codeflash Optimization PRsNo optimization PRs are mergeable — #1389 and #1291 both have failing CI checks ( Last updated: 2026-02-19T02:20Z |
KRRT7
added a commit
that referenced
this pull request
Feb 19, 2026
fix: include module-level variables and second-degree helpers in testgen helper FQNs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"statement"type) in Jedi helper resolution alongside functions and classestestgen_helper_fqnsfield toCodeOptimizationContextcontaining FQNs from both first-degree and second-degree helpershelper_function_namessent to the AI test generatorThis fixes generated tests importing symbols (e.g.,
_EXTENSION_REGISTRY) from the wrong module, which causedImportErrorand 0% test coverage.Test plan
get_files_for_languageand verify generated tests no longer produceImportErrorhelper_functionsensures backward compat)