ci: add path-based filtering to skip irrelevant workflows on PRs#1542
Closed
ci: add path-based filtering to skip irrelevant workflows on PRs#1542
Conversation
JS E2E workflows only trigger on JS-related file changes, Python E2E and unit test workflows skip when only JS/npm files change. Push to main and workflow_dispatch remain unfiltered.
test_multi_file_code_replacer.py depends on code_to_optimize/js/ fixtures, so unit tests need to trigger on JS fixture changes.
Contributor
PR Review SummaryPrek Checks✅ Passed — No Python files changed in this PR; prek and mypy have nothing to check. Code Review✅ No critical issues found. This PR adds path-based filtering to 16 GitHub Actions workflow files. The changes are well-structured:
Test Coverage⏭️ Skipped — No Python source files changed in this PR. All changes are to Last updated: 2026-02-19 |
Without these, workflow-only PRs never trigger the required checks, leaving them stuck at "Waiting for status to be reported".
Collaborator
Author
|
actually I'll think of a better way to do this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codeflash/languages/javascript/,packages/,code_to_optimize/js/, JS test files)!negation patterns)unit-tests,windows-unit-tests,mypy,prek) get path filters scoped to Python-relevant filescode_to_optimize/js/**included sincetest_multi_file_code_replacer.pydepends on JS fixturespush: branches: [main]andworkflow_dispatchremain unfilteredTest plan
packages/→ Python E2E/unit tests should not triggermainstill trigger everything (no path filter on push)workflow_dispatchstill works for all workflows