fix: add nonce to script-src-elem and style-src-elem when configured#9999
Merged
michalsn merged 1 commit intocodeigniter4:developfrom Feb 24, 2026
Merged
fix: add nonce to script-src-elem and style-src-elem when configured#9999michalsn merged 1 commit intocodeigniter4:developfrom
michalsn merged 1 commit intocodeigniter4:developfrom
Conversation
michalsn
added
the
bug
Member
paulbalandan
left a comment
paulbalandan
left a comment
There was a problem hiding this comment.
If I understand correctly from the spec, script-src already governs the other script-src-attr and script-src-elem directives. So, if someone calls getScriptNonce() which sets the nonce to script-src, should it be safe to assume that script-src-attr and script-src-elem don't need to have the same nonce as their source expressions? Same goes for style-src directive.
paulbalandan
approved these changes
Feb 24, 2026
Member
paulbalandan
left a comment
paulbalandan
left a comment
There was a problem hiding this comment.
I have read more and understood it fully. Thanks!
datamweb
approved these changes
Feb 24, 2026
Member
Author
|
Thank you for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where nonce wasn't added to
script-src-elem/style-src-elemwhen those directives were configured.Fixes #9992
Checklist: