Ensure Sheets render above native peers by enabling lightweight mode and adding blocker#4504
Closed
shai-almog wants to merge 3 commits intomasterfrom
Closed
Ensure Sheets render above native peers by enabling lightweight mode and adding blocker#4504shai-almog wants to merge 3 commits intomasterfrom
shai-almog wants to merge 3 commits intomasterfrom
Conversation
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
Android screenshot updatesCompared 30 screenshots: 29 matched, 1 updated.
Native Android coverage
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation
Sheetcould appear behind native peers (e.g.BrowserComponent) by making the form render in lightweight mode while the sheet is visible.Description
Formwhen showing a sheet ifForm.activePeerCount > 0by callingf.setLightweightMode(true)before showing and restoring it after the sheet is hidden.getSheetLayer(Container)helper that stores the layer in a client propertycn1$sheetLayerand centralizes layout/animation work.ensureSheetBlocker(Container, Container)which manages aSheetBlockercomponent stored under client propertycn1$sheetBlockerto block pointer events and cover the display when native peers exist, and remove it when no peers are active.SheetBlockerthat grabs pointer events and reports full-screen preferred size viacalcPreferredSize(); switch container layout toLayeredLayoutand update add/replace/animate calls to operate on the sheet layer.Dimensionand modifyBrowserComponentScreenshotTestto show aSheetduring the test to exercise the native-peer/sheet interaction scenario.Testing
BrowserComponentScreenshotTestwas adjusted to present aSheetto reproduce the issue, but the test was not run in this PR.Codex Task