fix: change k8s event log level from Info to Debug #157
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #145. Kubernetes events sent to Coder were displayed with a green border because they used LogLevelInfo. This confused users who associate green with 'workspace ready'. Changing to LogLevelDebug prevents these interim events from appearing with the same visual indicator as the final ready state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145
Summary
Kubernetes events sent from coder-logstream-kube to Coder were displayed with a green border because they used
LogLevelInfo. This confused users who associate green with "workspace ready".Changes
Changed
codersdk.LogLevelInfotocodersdk.LogLevelDebugin 3 places inlogger.go:This prevents the interim events (PVC/PV attach, image pull, etc.) from appearing with the same visual indicator as the final ready state.
Testing