refactor(vscode-web): migrate to VS Code CLI with code serve-web#627
Draft
refactor(vscode-web): migrate to VS Code CLI with code serve-web#627
Conversation
Member
matifali
commented
Dec 31, 2025
matifali
commented
- Replace code-server with official VS Code CLI
- Download CLI from code.visualstudio.com using cli-alpine-* URLs
- Add release_channel variable (stable/insiders)
- Add commit_id variable to pin specific VS Code versions
- Support offline mode with fallback to code-server or cached vscode-server
- Add comprehensive bun tests for settings, extensions, and CLI arguments
- Add Terraform tests for variable validation
- Replace code-server with official VS Code CLI - Download CLI from code.visualstudio.com using cli-alpine-* URLs - Add release_channel variable (stable/insiders) - Add commit_id variable to pin specific VS Code versions - Support offline mode with fallback to code-server or cached vscode-server - Add comprehensive bun tests for settings, extensions, and CLI arguments - Add Terraform tests for variable validation
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the vscode-web module to use the official VS Code CLI instead of code-server, enabling better version control and alignment with official VS Code tooling.
- Migrates from code-server to official VS Code CLI with
code serve-webcommand - Adds
release_channelvariable to support stable/insiders releases - Implements comprehensive offline mode with fallback to code-server or cached vscode-server
- Adds extensive test coverage with 21 new integration tests
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| main.tf | Removes platform variable, adds release_channel and repositions commit_id variable with updated description |
| run.sh | Complete rewrite to download and use VS Code CLI instead of code-server, with offline fallback mechanisms |
| main.test.ts | Adds comprehensive test suite with 21 tests covering script generation, settings management, extension installation, and container integration |
| vscode-web.tftest.hcl | New Terraform validation tests for variable constraints and URL generation |
| README.md | Updates documentation to reflect VS Code CLI usage and new configuration options |
Separate declaration and assignment for local variable to avoid masking return values.
… settings - Changed test description to reflect merging behavior of settings. - Updated Terraform variable description to clarify merging of settings. - Implemented a new function in the run script to merge settings using jq or Python3. - Adjusted the settings file creation logic to merge new settings with existing ones. - Updated README to reflect changes in settings configuration and merging requirements.
…installed after server starts - Added a sleep command to allow the VS Code Web server to start before installing extensions. - Modified the script to run the VS Code Web CLI first, followed by the installation of extensions.
…ensions - Added a function to wait for the VS Code Web server to be ready before proceeding with the installation of extensions. - Replaced sleep commands with a conditional wait to ensure extensions are only installed after the server is confirmed to be running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.