Skip to content

feat(KasmVNC): allow share variable to be passed with default: owner#709

Merged
matifali merged 4 commits intocoder:mainfrom
iamriajul:patch-1
Feb 11, 2026
Merged

feat(KasmVNC): allow share variable to be passed with default: owner#709
matifali merged 4 commits intocoder:mainfrom
iamriajul:patch-1

Conversation

@iamriajul
Copy link
Contributor

Description

This is a small enhancement to KasmVNC module, This is needed in scenarios where we want to give flexibility of sharing the Desktop Environment to demonstrate Desktop Application Demos.

Type of Change

  • New module
  • New template
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/coder/modules/kasmvnc
New version: v1.0.0
Breaking change: [ ] Yes [x] No

Template Information

Path: registry/[namespace]/templates/[template-name]

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun fmt)
  • Changes tested locally

Related Issues

Code Server module already supports, so I had just copy-pasted that feature into here in this module.

This is needed in scenarios where we want to give flexibility of sharing the Desktop Environment to demonstrate Desktop Application Demos.
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please bump the minor version using the script, and it's good to merge.

./.github/scripts/version-bump.sh minor

@iamriajul
Copy link
Contributor Author

Done

@matifali
Copy link
Member

Once the CI passes, I can merge. Check the failed CI run: https://github.com/coder/registry/actions/runs/21852884352/job/63063359653?pr=709

@iamriajul
Copy link
Contributor Author

Fixed

@matifali matifali enabled auto-merge (squash) February 11, 2026 07:34
@matifali matifali merged commit 0449051 into coder:main Feb 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants