fix: render error types as strings in human log sink#224
Merged
dannykopping merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 50d5187765f31c6188695fe1e5f9dbc17378f68f-PR-224Details
💛 - Coveralls |
dannykopping
force-pushed
the
dk/err-formatting
branch
6 times, most recently
from
028fb71 to
e694146
Compare
`formatValue` checked `reflect.Struct` before checking the `error`
interface, so struct-typed errors like `context.DeadlineExceeded`
were serialized via `json.Marshal` as `{}` instead of their error
string.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dannykopping
force-pushed
the
dk/err-formatting
branch
from
e694146 to
eb52634
Compare
ethanndickson
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatValueinentryhumancheckedreflect.Structbefore theerrorinterface, so struct-typed errors (e.g.context.DeadlineExceeded) were JSON-marshaled as{}instead of their.Error()string.error/fmt.Stringertype check before the struct/map path, matching the existing pattern inmap.go:encode().Test plan
TestContextErrorFormattinginentryhumancoveringDeadlineExceeded,Canceled, and wrapped errorsTestContextErrorsinslogjsonfor end-to-end coveragecontextDeadlineExceeded/contextCanceledcases inTestMap🤖 Generated with Claude Code