Javascript package decomposition#153
Open
Reversean wants to merge 6 commits intorefactor/catcher-loggerfrom
Open
Javascript package decomposition#153Reversean wants to merge 6 commits intorefactor/catcher-loggerfrom
Reversean wants to merge 6 commits intorefactor/catcher-loggerfrom
Conversation
Reversean
force-pushed
the
chore/yarn-4.12.0
branch
3 times, most recently
from
ce72cfd to
5220d8c
Compare
Reversean
force-pushed
the
refactor/javascript-package-decomposition
branch
from
b1e27b1 to
e943476
Compare
Reversean
changed the title
Reversean
force-pushed
the
refactor/javascript-package-decomposition
branch
from
e943476 to
2b74325
Compare
Reversean
changed the title
neSpecc
reviewed
Feb 3, 2026
Member
There was a problem hiding this comment.
I think this file is bloated and a significant part of it can be reusable as a core module.
- we can create an abstract class definining base structure of any catcher.
type(protected),context,user,getIntegrationId, getRelease, getType, getRawData, etc can be moved there. - setUser, setContext - reusable
- maybe some other utilities.
StackParser, etc
Member
Author
There was a problem hiding this comment.
I think I'll move catcher core in separate PR. This PR takes only common env-agnostic utilities and modules.
But this comment noticed.
Reversean
force-pushed
the
refactor/javascript-package-decomposition
branch
from
2b74325 to
e8010d5
Compare
Reversean
force-pushed
the
refactor/javascript-package-decomposition
branch
from
e8010d5 to
20726ad
Compare
Reversean
force-pushed
the
refactor/catcher-logger
branch
from
70d214e to
fc05da3
Compare
Reversean
changed the title
Reversean
force-pushed
the
refactor/javascript-package-decomposition
branch
from
20726ad to
b4018fb
Compare
Reversean
force-pushed
the
refactor/catcher-logger
branch
from
fc05da3 to
8ad3d96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved common utilities and types to
@hawk.so/core:SanitizerStackParserTransportEventRejectedErrorfetch-timer.tsevent.tsselector.tsvalidation.tsSome types are now re-export of types from
@hawk.so/types:CatcherMessageHawkJavaScriptEvent