Conversation
c3013b6 to
223001d
Compare
neSpecc
approved these changes
Feb 17, 2026
There was a problem hiding this comment.
Pull request overview
Adds an environment-agnostic storage abstraction to @hawk.so/core and introduces a browser localStorage-backed implementation in @hawk.so/javascript, aligning with the repo’s ongoing split between shared core logic and runtime-specific implementations (Issue #151).
Changes:
- Added
HawkStorageinterface to@hawk.so/coreand exported it from the core entrypoint. - Added
HawkLocalStorageimplementation and corresponding unit tests in@hawk.so/javascript. - Added Vitest coverage support/config updates for the JavaScript package.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Adds dependencies for Vitest v8 coverage reporting. |
| packages/javascript/tsconfig.test.json | Adds Vitest globals types to the test TS config. |
| packages/javascript/tests/storages/hawk-local-storage.test.ts | Introduces unit tests for the new HawkLocalStorage. |
| packages/javascript/src/storages/hawk-local-storage.ts | Adds a localStorage-backed HawkStorage implementation. |
| packages/javascript/package.json | Adds test:coverage script and coverage dependency. |
| packages/core/src/storages/hawk-storage.ts | Adds the storage interface contract in core. |
| packages/core/src/index.ts | Exports HawkStorage from the core public entrypoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cd47f1e to
7c1ad96
Compare
7c1ad96 to
591724a
Compare
FeironoX5
reviewed
Feb 26, 2026
d4c780e to
591724a
Compare
FeironoX5
approved these changes
Feb 26, 2026
591724a to
a2abcb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #151
Added
HawkStorageinterface which could be used as env-agnositc abstraction to store key-values.Also
HawkLocalStorageimplementation based on browserlocalStorageadded.